Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with all supported versions (drop Python 3.3 support) #60

Closed
2 tasks done
chrysn opened this issue Mar 20, 2017 · 2 comments
Closed
2 tasks done

Run tests with all supported versions (drop Python 3.3 support) #60

chrysn opened this issue Mar 20, 2017 · 2 comments

Comments

@chrysn
Copy link
Owner

chrysn commented Mar 20, 2017

If it isn't tested, it doesn't work. Worse enough the code coverage is not near 100% yet, but Python 3.4 continuously breaks due to old syntax glitches, careless use of 3.5 idioms and what so not.

Mitigation:

  • Run CI on all supported versions
  • Drop Python 3.3 support because while the Gitlab CI runners do support it, I can't eaily reproduce failures in development because no stable Debian release shipped that version.

(Those applications I had in mind that justified Python 3.3 support, PyPy and micropython, would need dedicated tests anyway. If you want to run aiocoap on a particular Python 3.3 setup, open an issue and we'll figure something out.)

@aellwein
Copy link
Contributor

aellwein commented Mar 20, 2017 via email

@chrysn
Copy link
Owner Author

chrysn commented Mar 21, 2017

(Stupid question? Not at all!)

I do use aiocoap on our production servers that run Debian Jessie (and thus Python 3.4.2). The main cost of supporting Python 3.4/3.5 right now is not using modern async def idiom in the core parts (a minor annoyance), and sporadic bugs that only got caught late so far because the test suite didn't cover 3.4 (eg. whatever syntax oddity there was that made 1993947 necessary, async details I missed like d3669b7 or f5b58d2).

My rough roadmap w/rt old versions right now is to support whatever Python version is in the latest Debian release. (Fedora and Ubuntu with their shorter release cycles should be covered by this too). Feedback like yours helps in that decision; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants