Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classification evaluation for LLaVA #4

Open
rishika2110 opened this issue Mar 5, 2024 · 5 comments
Open

Classification evaluation for LLaVA #4

rishika2110 opened this issue Mar 5, 2024 · 5 comments

Comments

@rishika2110
Copy link

Hi, currently, the code throws a NotImplementedError for LLaVA, but I believe the paper demonstrates zero-shot classification on LLaVA. When will the code be updated to include this feature? Alternatively, could you point out the main parts that would need significant changes to incorporate LLaVA?

Thank you.

@chs20
Copy link
Owner

chs20 commented Mar 5, 2024

Hi, thanks for asking. We demonstrate zero-shot classification only for the CLIP models on their own and consider LLaVA and OpenFlamingo for captioning/VQA tasks.

@rishika2110
Copy link
Author

rishika2110 commented Mar 7, 2024

Thank you for the clarification. I have another question: Why is the batch size hardcoded to 1? Is it just to avoid padding text tokens? Or am I missing something?

@chs20
Copy link
Owner

chs20 commented Mar 9, 2024

You're right, it should definitely be possible to run with larger batch sizes, it's just hardcoded to batch_size 1 in a few places since we couldn't fit much more on our devices anyway for adversarial evaluations

@rishika2110
Copy link
Author

Hi, thank you so much for clarifying everything. Just one last question: does the code use beam search to generate the outputs?

@chs20
Copy link
Owner

chs20 commented May 14, 2024

No problem :) We basically stick to how the models are evaluated in their respective papers, so greedy decoding without beam-search for LLaVA, and beam search with 3 beams for OpenFlamingo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants