Enhance: introduce ReadDirLimit_ll request #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuoranliu
force-pushed
the
readdirlimit
branch
3 times, most recently
from
570cf8e
to
76737f3
Compare
shuoranliu
force-pushed
the
readdirlimit
branch
3 times, most recently
from
7e149bc
to
4f507af
Compare
This commit introduces a new request in metanode which returns limited number of dentries starting from 'marker', but not all the dentries in a directory. Because in S3 interface, the client usually does not want to retrieve all the objects in a single request. This commit can offload the ReadDir overhead of metanodes significantly if there are millions of objects in a single directory and objectnode is retrieving only 1000 of the dentries. Signed-off-by: zhuzhengyi001 <zhuzhengyi001@ke.com> Signed-off-by: Shuoran Liu <shuoranliu@gmail.com>
Signed-off-by: zhuzhengyi001 <zhuzhengyi001@ke.com>
Suppose there are several files under the root directory: /a000, /a001,
/a002, /a003, /ab000, /ab001
Issue a ListObjects request with the following parameters: Prefix[/ab],
MaxKeys[2], ContinuationToken[], then there is no entries returned since
metanode returns {/a000, /a001} in such circumstance which are all
smaller than the Prefix.
This commit compares the Prefix and ContinuationToken and takes the
larger one as search starting point.
Signed-off-by: Shuoran Liu <shuoranliu@gmail.com>
shuoranliu
force-pushed
the
readdirlimit
branch
from
4f507af
to
cf6acbb
Compare
shyodx
approved these changes
Oct 14, 2021
awzhgw
pushed a commit
that referenced
this pull request
Jan 21, 2024
… 17:44:32 fix: multirate concurrency panic on reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new request in metanode which returns limited
number of dentries starting from 'marker', but not all the dentries in
a directory. Because in S3 interface, the client usually does not want
to retrieve all the objects in a single request. This commit can offload
the ReadDir overhead of metanodes significantly if there are millions of
objects in a single directory and objectnode is retrieving only 1000 of
the dentries.
Signed-off-by: zhuzhengyi001 zhuzhengyi001@ke.com
Signed-off-by: Shuoran Liu shuoranliu@gmail.com
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: