fix: start tcp listen before starting raft #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuoranliu
force-pushed
the
fix-start-tcp-before-raft
branch
3 times, most recently
from
58dfcee
to
f6f0a43
Compare
This commit starts the TCP listen port before starting raft. Because otherwise there is a gap between raft started and TCP port listened. If current node is selected as raft leader but TCP port listening is not up, the whole partition will be unavailable due to "connnection reset error". Signed-off-by: Shuoran Liu <shuoranliu@gmail.com>
shuoranliu
force-pushed
the
fix-start-tcp-before-raft
branch
from
f6f0a43
to
38fb340
Compare
shyodx
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit starts the TCP listen port before starting raft. Because
otherwise there is a gap between raft started and TCP port listened. If
current node is selected as raft leader but TCP port listening is not
up, the whole partition will be unavailable due to "connnection reset
error".
Signed-off-by: Shuoran Liu shuoranliu@gmail.com
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: