fix: remove redundant memcopy when reading raft snapshot #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the redundant memcopy when reading raft snapshot. The redundant memcopy makes reading snapshot very slow which leads to snapshot send failure. Signed-off-by: leonrayang <chl696@sina.com> Reviewd-by: Shuoran Liu <shuoranliu@gmail.com>
shuoranliu
force-pushed
the
fix-raft-remove-redundant-memcpy-when-reading-snapshot
branch
from
4d2a338
to
e18bf7b
Compare
leonrayang
approved these changes
Nov 17, 2021
shuoranliu
deleted the
fix-raft-remove-redundant-memcpy-when-reading-snapshot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the redundant memcopy when reading raft snapshot.
The redundant memcopy makes reading snapshot very slow which leads to
snapshot send failure.
Signed-off-by: leonrayang chl696@sina.com
Reviewd-by: Shuoran Liu shuoranliu@gmail.com
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: