fix: handle bytes=0-
correctly in objectnode
#1286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients (e.g. docker registry) send a get to fetch the whole file
by specifying
bytes=0-
as the range. In this case, ChubaoFS will setthe range to 0-0 and the
Content-Length
to 1 (upper - lower + 1). Itwill then error out when writing the object, since it will write more
than the specified
Content-Length
.As a simple fix, we can treat a rangeUpper of 0 the same as max, which
should result in correct behavior.
Special notes for your reviewer: I'm not able to build chubaofs locally (errors while building rocksdb), so I haven't been able to test this change.
Release note: