Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work on handling ja_JP properly since WP doesn't #19

Open
chuckreynolds opened this issue Apr 10, 2013 · 3 comments
Open

work on handling ja_JP properly since WP doesn't #19

chuckreynolds opened this issue Apr 10, 2013 · 3 comments

Comments

@chuckreynolds
Copy link
Owner

This is one request of many. http://wordpress.org/support/topic/oglocale-for-japan-needs-a-little-change

I'd like to not get to a point where it needs to be a dropdown in settings but that's super super last resort. Should just handle with locale() but fix WP's weirdness.

@andrewryno
Copy link
Contributor

I'll at the very least add the apply_filters() call around it. Not sure why I skipped that when I did every other meta tag.

@ToshiOshio
Copy link

Hi, I haven't noticed your github repo until now. I added a custom locale setting to its option page. Could a pull request be a little help?

@chuckreynolds
Copy link
Owner Author

@ToshiOshio I'd hate to add another option - I'd rather have something that converts them to the proper locale all behind-the-scenes. I know wordpress-seo and the Facebook plugin did that too. I've just never gotten around to it.
If you do work on a PR - please do it on develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants