Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deck attribute might yeld error: use dataclass and efficent error handling #1

Closed
chumpblocckami opened this issue Feb 25, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@chumpblocckami
Copy link
Owner

As is, when costructing a deck, we pass the attributes in dict as we download them: this might cause error, for both error in downloading or attributes that are missing (such as archetype).

We probably need better handling of those imputs, both in deck and tournament class.

@chumpblocckami chumpblocckami added the good first issue Good for newcomers label Feb 25, 2022
@chumpblocckami chumpblocckami self-assigned this Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant