Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive memory usage since 3d biome support was added #1327

Closed
almrausch opened this issue Jun 29, 2022 · 1 comment · Fixed by #1329
Closed

Excessive memory usage since 3d biome support was added #1327

almrausch opened this issue Jun 29, 2022 · 1 comment · Fixed by #1329
Labels
bug snapshot-only Issues that only affect Chunky snapshots
Milestone

Comments

@almrausch
Copy link
Contributor

It seems like the commit "Add 3d biomes and 3d blur (off by default) (#1225)" makes Chunky use drastically more memory when loading a scene. Loading scenes with more than 200k chunks has been no problem for me before, but now I run out of memory when loading scenes with as little as 20k chunks.

@leMaik leMaik changed the title Excessive memory usage with 3d biomes Excessive memory usage since 3d biome support was added Jun 30, 2022
@leMaik leMaik added bug snapshot-only Issues that only affect Chunky snapshots labels Jun 30, 2022
@leMaik leMaik added this to the 2.5.0 milestone Jun 30, 2022
@jackjt8
Copy link
Member

jackjt8 commented Jul 3, 2022

So after bisecting and manual testing we have been able to confirm that memory usage does increase by a significant amount after #1225. In my testing on 2.4.2 we would typically see ~1.8GB for a 4 region selection. This balloons up to 8GB for snapshots post 1225.

The trival2d structures retained size compared to next largest and "unchanged" from previous versions.

    Trivial2dBiomeStructure - 1GB
    Trivial2dBiomeStructure - 1GB
    Trivial2dBiomeStructure - 1GB
    Octree                  - 0.3GB

WORLD-TEXTURE-2D in #1329 should restore memory usage to 2.4.2 levels.

We have noticed what appears to be excessive allocation in 2.5.0 compared to 2.4.2. However tracking down exactly what is going on is so far proving difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug snapshot-only Issues that only affect Chunky snapshots
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants