Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome colors are incorrect in the latest snapshot, and change depending on biomes within chunk selection #1343

Closed
Peregrine05 opened this issue Jul 7, 2022 · 5 comments · Fixed by #1344
Labels
bug snapshot-only Issues that only affect Chunky snapshots

Comments

@Peregrine05
Copy link
Member

Depending on the biomes within the chunk selection, the colors of all of the foliage change to that of one of the biomes in the chunk selection. The color changes depending on the biomes within the selection.

Biome_incorrect_1

Biome_incorrect_2

@Peregrine05
Copy link
Member Author

image

@Peregrine05
Copy link
Member Author

This problem appears to have first started after PR #1225 was merged. Before that version, worlds that currently exhibit this effect in Chunky do not exhibit this effect. Versions after the PR was merged do exhibit this effect.

I have tested worlds created in different Minecraft versions. 1.6.x (1.6.4) was the earliest version that I could test.
The results are below.

1.6.4: OK
1.7.10: OK
1.8.9: OK
1.9.4: OK
1.10.2: OK
1.11.2: OK
1.12.2: OK
1.13.2: OK
1.14.4: OK
1.15.2: Broken
1.16.5: Broken
1.17.1: Broken
1.18.2: Broken
1.19: OK

I assume that worlds created in versions 1.2.1 to 1.5.x would also work normally.

@Peregrine05
Copy link
Member Author

Yet strangely enough, some 1.18 worlds do work normally.

@NotStirred
Copy link
Member

NotStirred commented Jul 7, 2022

seems like the nbt alias is messed up somehow, from the versions you said

@leMaik leMaik added bug snapshot-only Issues that only affect Chunky snapshots labels Jul 7, 2022
@NotStirred
Copy link
Member

Ok I see how this happened, quite a weird one to find.
Basically we were always loading the palette structure as 3d, even if 3d biomes was disabled.

Will push a PR
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug snapshot-only Issues that only affect Chunky snapshots
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants