Code not easily searchable

[vysecurity]

Issue Description

The code was not easily identifiable, making it more difficult to maintain or identify areas for modification.

E.g.

NimPlant/server/util/listener.py

Line 27 in ff66479

b_ident = b"789CF3CBCC0DC849CC2B51703652084E2D2A4B2D02003B5C0650"

For some reason the Server header is encoded in hex. If it was in just plain text we could grep for the string and change it.

---

Improvement

Put the cleartext server header in the code instead of the hex representation because it's running on the server anyways.

Also, what was the reason to use base16 on it? It's unlikely anyone would run this on the target system with Python installed, so obfuscation isn't really necessary.

[chvancooten]

Hi Vincent, that Server header was encoded like that on purpose, exactly so that people can't just grep for it to change it 😉. Motivation being that people should actually go through the code at least a bit and make appropriate modifications before deploying.

Closing this as a won't-fix issue. Feel free to open a new issue or PR if you have any other suggestions!

[vysecurity]

Got it!