Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use code-connect when code is installed #8

Merged
merged 8 commits into from Feb 18, 2021
Merged

Don't use code-connect when code is installed #8

merged 8 commits into from Feb 18, 2021

Conversation

chvolkmann
Copy link
Owner

@chvolkmann chvolkmann commented Feb 17, 2021 •
edited

Summary

  • Redirect arguments directly to a locally installed code binary if detected in PATH. Useful in the integrated terminal as PATH will be populated with a code binary (set up beforehand by VS Code). We already have an executable available, no need to find it ourselves with code_connect.py.
  • Add function code-connect to connect through IPCs explicitly
  • Add fancy bash installer
  • Add bash uninstaller
  • Move bash-related files

Fixes #7

Checklist

  • fish
  • bash
  • docs

@chvolkmann
feat(fish): Don't use code-connect when code is installed
a330dc9 
Add function code-connect to connect through IPCs explicitly

Fixes #7
@chvolkmann chvolkmann self-assigned this Feb 17, 2021
@chvolkmann chvolkmann added enhancement New feature or request fix A bugfix labels Feb 17, 2021
@chvolkmann chvolkmann added this to the 0.3.0 milestone Feb 17, 2021
@chvolkmann chvolkmann marked this pull request as ready for review February 18, 2021 00:00
@chvolkmann chvolkmann merged commit f39dc64 into dev Feb 18, 2021
@chvolkmann chvolkmann deleted the chvolkmann/issue7 branch February 18, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chvolkmann chvolkmann

Labels
enhancement New feature or request fix A bugfix
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Don't use code-connect when in integrated terminal
1 participant
@chvolkmann