Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias support #8

Closed
hoodie opened this issue Nov 27, 2015 · 5 comments
Closed

alias support #8

hoodie opened this issue Nov 27, 2015 · 5 comments

Comments

@hoodie
Copy link
Contributor

hoodie commented Nov 27, 2015

Hey, I just noticed that alias were intended but are not fully implemented.
I could use this feature.
Could you finish it or perhaps give me some hints so I can do it?
Thank you.

@chyh1990
Copy link
Owner

Alias is on the TODO list. The scanner & parser do support alias, but the top level YamlLoader leaves it unimplemented.

See https://github.com/chyh1990/yaml-rust/blob/master/src/yaml.rs#L140

I'll implement it next week if I have time :-)

@hoodie
Copy link
Contributor Author

hoodie commented Nov 29, 2015

Hey, thanks. I'd already found that line, and started thinking about just sending you a PR, but I found it a bit too complicated for a quick contribution.

@hoodie
Copy link
Contributor Author

hoodie commented Dec 11, 2015

Hey there :D

@chyh1990
Copy link
Owner

here's my implementation, not tested much

https://github.com/chyh1990/yaml-rust/tree/alias

@hoodie
Copy link
Contributor Author

hoodie commented Dec 16, 2015

Thanks, I'll put it to the test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants