Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible deadline situation when reading NUL bytes #87

Closed
knz opened this issue Oct 5, 2016 · 3 comments
Closed

possible deadline situation when reading NUL bytes #87

knz opened this issue Oct 5, 2016 · 3 comments

Comments

@knz
Copy link

knz commented Oct 5, 2016

See cockroachdb/cockroach#9607 for details.

@chzyer
Copy link
Owner

chzyer commented Oct 6, 2016

@knz Could you help me to test that can this pr fix this deadlock? Thanks.

@knz
Copy link
Author

knz commented Oct 6, 2016

To test this properly I think there is no choice and you have to perform a stress test (many hundreds calls of the problem).
I tested with this:

for ((i=0;i<10000;i++)); do printf 'bye\x00' | ./readline-demo; done

No error found any more after 10000 runs, so the situation is now definitely better! 👍

@chzyer
Copy link
Owner

chzyer commented Oct 7, 2016

Thanks, @knz

@chzyer chzyer closed this as completed Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants