model group_start, group_end

[disccomp]

These methods are relatively new to CI, so I thought some discussion might be in order on whether these should be included in BF_Model. Or if there is a preferred method to group where clauses.

public function group_start(){
    $this->db->group_start();
    return $this;
}

public function group_end(){
    $this->db->group_end();
    return $this;
}

[mwhitneysdsu]

I don't think I would have a problem with merging a pull request in develop which adds another group of db wrappers to BF_Model. However, over time I've found that I no longer use them as much as I did when we originally added them.

Quite a few methods were added to DB_query_builder with CI3, and one reason they weren't added when CI3 support was added to Bonfire was simply because it also needed to support CI2. Some technical issue on my end stopped me from releasing 0.8.4 at the time that I released 0.7.8, but that's only related to this because the 0.8.4 release will be the last one which is intended to be compatible with CI 2 (0.8.4 would come from the 0.8-dev branch, not develop).

So, what it comes down to, really, is deciding which wrappers are worth adding for the new methods added by CI3. Certainly, if you're going to add group_start() and group_end(), the other query grouping methods should be added as well.