Test::Unit::Omission and Test::Unit::Pending broken in Ruby 1.9 #27

Closed
bwilliams opened this Issue Apr 2, 2011 · 3 comments

Comments

Projects
None yet
2 participants

Hi, you recently took in a patch to allow Test Unit Omissions and Pendings. It doesn't work in Ruby 1.9 because constants are symbols instead of strings now. Please update line 16 of lib/ci/reporter/test_unit.rb to check Test::Unit.constants for either "Omission" or :Omission

on second thought, it'd be simpler this way:
change
Test::Unit.constants.include?("Omission")
to
defined?(Test::Unit::Omission)

That should work in both 1.8 and 1.9

shepmaster removed the 1.7.0 label Jun 3, 2014

Owner

shepmaster commented Jun 12, 2014

We are in the process of cleaning out old issues. Specifically, the
next version of CI::Reporter is only going to support Test::Unit
bundled with the latest version of Ruby 1.9.3, 2.0, and 2.1. If this
issue still applies to these versions, please let us know, otherwise
we're going to close this issue to focus on current problems. Thanks
for your report!

Owner

shepmaster commented Jul 22, 2014

Closing due to inactivity.

shepmaster closed this Jul 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment