Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test::Unit::Omission and Test::Unit::Pending broken in Ruby 1.9 #27

Closed
bwilliams opened this issue Apr 2, 2011 · 3 comments
Closed

Comments

@bwilliams
Copy link

Hi, you recently took in a patch to allow Test Unit Omissions and Pendings. It doesn't work in Ruby 1.9 because constants are symbols instead of strings now. Please update line 16 of lib/ci/reporter/test_unit.rb to check Test::Unit.constants for either "Omission" or :Omission

@bwilliams
Copy link
Author

on second thought, it'd be simpler this way:
change
Test::Unit.constants.include?("Omission")
to
defined?(Test::Unit::Omission)

That should work in both 1.8 and 1.9

@shepmaster
Copy link
Member

We are in the process of cleaning out old issues. Specifically, the
next version of CI::Reporter is only going to support Test::Unit
bundled with the latest version of Ruby 1.9.3, 2.0, and 2.1. If this
issue still applies to these versions, please let us know, otherwise
we're going to close this issue to focus on current problems. Thanks
for your report!

@shepmaster
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants