Skip to content

Commit

Permalink
Merge pull request #150 from joserobleda/master
Browse files Browse the repository at this point in the history
Use hasOwnProperty to prevent erros
  • Loading branch information
ciaranj committed May 21, 2014
2 parents 4e351fe + 89f7972 commit 0707eb8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/oauth.js
Expand Up @@ -140,6 +140,7 @@ exports.OAuth.prototype._buildAuthorizationHeaders= function(orderedParameters)
exports.OAuth.prototype._makeArrayOfArgumentsHash= function(argumentsHash) { exports.OAuth.prototype._makeArrayOfArgumentsHash= function(argumentsHash) {
var argument_pairs= []; var argument_pairs= [];
for(var key in argumentsHash ) { for(var key in argumentsHash ) {
if (argumentsHash.hasOwnProperty(key)) {
var value= argumentsHash[key]; var value= argumentsHash[key];
if( Array.isArray(value) ) { if( Array.isArray(value) ) {
for(var i=0;i<value.length;i++) { for(var i=0;i<value.length;i++) {
Expand All @@ -149,6 +150,7 @@ exports.OAuth.prototype._makeArrayOfArgumentsHash= function(argumentsHash) {
else { else {
argument_pairs[argument_pairs.length]= [key, value]; argument_pairs[argument_pairs.length]= [key, value];
} }
}
} }
return argument_pairs; return argument_pairs;
} }
Expand Down Expand Up @@ -274,7 +276,7 @@ exports.OAuth.prototype._prepareParameters= function( oauth_token, oauth_token_s
else { else {
if( extra_params ) { if( extra_params ) {
for( var key in extra_params ) { for( var key in extra_params ) {
oauthParameters[key]= extra_params[key]; if (extra_params.hasOwnProperty(key)) oauthParameters[key]= extra_params[key];
} }
} }
var parsedUrl= URL.parse( url, false ); var parsedUrl= URL.parse( url, false );
Expand Down

0 comments on commit 0707eb8

Please sign in to comment.