Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test helper can't center calendar due to incorrect use of dataset property #465

Closed
nickschot opened this issue Apr 8, 2024 · 0 comments · Fixed by #466
Closed

Test helper can't center calendar due to incorrect use of dataset property #465

nickschot opened this issue Apr 8, 2024 · 0 comments · Fixed by #466

Comments

@nickschot
Copy link
Contributor

After updating I ran into this issue where some of our tests would fail due to the test helpers not being able to find the calendar by guid anymore.

It appears this change was introduced here: 45c804f#diff-ea2ebf3d8d042f0515ae852d46206a5beaeebcd1760bd9a71f2cd48ef1ba1a59R36

The solution would be to change return maybeCalendar.dataset['dataPowerCalendarId']; into return maybeCalendar.dataset['powerCalendarId'];

See also: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix use of dataset API in findCalendarGuid test-helper nickschot/ember-power-calendar
1 participant
@nickschot