Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear why tagging is necessary in twiddledum solution #59

Closed
jasonculligan opened this issue May 15, 2023 · 2 comments
Closed

Unclear why tagging is necessary in twiddledum solution #59

jasonculligan opened this issue May 15, 2023 · 2 comments

Comments

@jasonculligan
Copy link

https://github.com/cider-security-research/cicd-goat/blame/01cd2a4b317fb5d2327435f432c691162a136c73/solutions/twiddledum.md#L11

Reading the solution for twiddledum, it doesn't explain why tagging is necessary for the exploit to work. The requirement to tag should be made more clear.

@kairat1115
Copy link

Hi @jasonculligan, that is how package.json references to dependency with git url https://docs.npmjs.com/cli/v9/configuring-npm/package-json#git-urls-as-dependencies

If the commit-ish has the format #semver:, can be any valid semver range or exact version, and npm will look for any tags or refs matching that range in the remote repository, much as it would for a registry dependency

@TupleType
Copy link
Collaborator

Hey @jasonculligan,
Great point, could you create a PR with the proposed changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants