Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed instanceOf throws error when not function #117

Open
JackCA opened this issue Apr 11, 2017 · 0 comments
Open

failed instanceOf throws error when not function #117

JackCA opened this issue Apr 11, 2017 · 0 comments

Comments

@JackCA
Copy link
Contributor

JackCA commented Apr 11, 2017

I believe there is an unsafe assumption on this line because .toString() on an object doesn't always have the string function() in it.

A simple example is an array:

[1,2].toString()
"1,2"

in a scenario like this, you'll get the following error on the above referenced line: Cannot read property '1' of null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JackCA