You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose that we support the ability for the Node version to be set via a property so that when present it will be used in the scripts and when it is not then a/the default value is used. A likely candidate for where this property could be set is in the .pr-bumper.json file.
This will reduce the need for having to update the version of pr-bumper used in order to get a version of Node only if pr-bumper was released against/for the version desired.
The text was updated successfully, but these errors were encountered:
I'm a little confused, isn't that exactly what PUBLISH_NODE_VERSION lets you do? The 8.1.2 is only used if PUBLISH_NODE_VERSION isn't provided in the environment.
Currently we look for a hard-coded Node version in various scripts, for example
if [[ ! "${PUBLISH_NODE_VERSION:-8.1.2}" =~ ^$TRAVIS_NODE_VERSION ]]
in https://github.com/ciena-blueplanet/pr-bumper/blob/master/.travis/maybe-bump-version.sh#L10I propose that we support the ability for the Node version to be set via a property so that when present it will be used in the scripts and when it is not then a/the default value is used. A likely candidate for where this property could be set is in the .pr-bumper.json file.
This will reduce the need for having to update the version of
pr-bumper
used in order to get a version of Node only ifpr-bumper
was released against/for the version desired.The text was updated successfully, but these errors were encountered: