Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Comment on PR if missing version directive #25

Open
zakhenry opened this issue Apr 7, 2016 · 3 comments
Open

[Feature Request] Comment on PR if missing version directive #25

zakhenry opened this issue Apr 7, 2016 · 3 comments

Comments

@zakhenry
Copy link
Contributor

zakhenry commented Apr 7, 2016

It would be helpful for those unfamiliar with pr-bumper if it could comment on pull requests when pr-bumper check fails. Bonus if the comment could be customised in .github/PR_BUMPER_COMMENT_TEMPLATE.md

https://github.com/blog/2111-issue-and-pull-request-templates

@job13er
Copy link
Contributor

job13er commented May 16, 2016

That's a great idea, I'll try to give it a shot.

@job13er
Copy link
Contributor

job13er commented Mar 14, 2017

I'd like to also comment on the PR in other situations, like notifying of code coverage changes, notifying of missing #CHANGELOG section, etc.

@job13er
Copy link
Contributor

job13er commented Jun 8, 2017

Sadly, I haven't had much success with this, not because of the code involved, but because of the permissions. If you only have PRs from within your repo (branch to branch) it could probably work. We have it working fine in our private bitbucket, but the permissions needed for posting a comment are greater than the permissions needed to simply read the PR description, and since we can't encrypt secure tokens when building a PR build from outside the repo, I haven't been able to figure out how to let pr-bumper post comments w/o exposing credentials one wouldn't want to expose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants