Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support suppression of reading of pr description for CHANGELOG.md content #43

Closed
zakhenry opened this issue May 23, 2016 · 2 comments
Closed

Comments

@zakhenry
Copy link
Contributor

zakhenry commented May 23, 2016

I use https://github.com/conventional-changelog/gulp-conventional-changelog to build my changelog from commits, which conflicts with the new pr-bumper functionality. The pr-bumper.json file should be configurable to suppress this feature if not desired.

@job13er
Copy link
Contributor

job13er commented May 23, 2016

Valid point. I'm not sure how quickly we (or I) will get to this though. In the meantime, you can explicitly install the version before the CHANGELOG.md stuff using npm install -g pr-bumper@0.3.5 or you can submit a PR with the change yourself. The code where you'd want to put it is probably right around here for reading more info from .pr-bumper.json and here for actually skipping the check.

You could probably just do a check on the config option and return a Promise.resolve() in the case you want to skip prepending the CHANGELOG.md.

@job13er
Copy link
Contributor

job13er commented May 23, 2016

Also, if you do opt for the PR route (pretty please), then please also update the README.md with some info on the new option in .pr-bumper.json :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants