You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The total percentage of statements covered, or total.statements.pct is what is currently considered, per https://github.com/ciena-blueplanet/pr-bumper#code-coverage, however total.branches.pct should be considered as well. The reason for this is because even though a statement of code may be evaluated, not all of the code branches inside of it may be.
An example of this scenario that has been encountered is:
where the || '' conditions where never being tested but the statement was reported as being covered.
The pr-bumper.coverage property in the package.json file needs to remain a % value less than 100 so we cannot simply add these two numbers together but instead should average them. This assumes that the averaging of these two numbers gives us an accurate representation of what we are after. If this approach is chosen, it needs to be determined if the combined value would still accurately reflect an improvement in code coverage without the value decreasing.
The text was updated successfully, but these errors were encountered:
The total percentage of statements covered, or
total.statements.pct
is what is currently considered, per https://github.com/ciena-blueplanet/pr-bumper#code-coverage, howevertotal.branches.pct
should be considered as well. The reason for this is because even though a statement of code may be evaluated, not all of the code branches inside of it may be.An example of this scenario that has been encountered is:
where the
|| ''
conditions where never being tested but the statement was reported as being covered.The
pr-bumper.coverage
property in the package.json file needs to remain a % value less than 100 so we cannot simply add these two numbers together but instead should average them. This assumes that the averaging of these two numbers gives us an accurate representation of what we are after. If this approach is chosen, it needs to be determined if the combined value would still accurately reflect an improvement in code coverage without the value decreasing.The text was updated successfully, but these errors were encountered: