changed component action to CamelCase. filled in readme. updated demo to show code. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``` | ||
| {{#frost-checkbox | ||
| id='errored' | ||
| classNameBindings='error' |
There was a problem hiding this comment.
class instead of binding (for most cases)?
There was a problem hiding this comment.
Actually, do we need this at all in the docs?
|
A few changes/questions to address prior to approval |
|
@psbanka @cstolli @job13er @sandersky More eyes on the proposal for the major version of checkbox to be included in |
|
👍 |
| @@ -7,7 +7,7 @@ | |||
| name=name | |||
| update=(action 'input') | |||
| }} | |||
| <label for={{inputId}} class='label'>{{yield}} | |||
| <label for={{inputId}} class='label'>{{label}} | |||
There was a problem hiding this comment.
This needs to be conditional http://emberjs.com/api/classes/Ember.Component.html#property_hasBlock
|
@rox163 I assume this PR can be closed as the checkbox was moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
major