Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frost-textarea should support text alignment #537

Open
sandersky opened this issue Jan 17, 2018 · 2 comments
Open

frost-textarea should support text alignment #537

sandersky opened this issue Jan 17, 2018 · 2 comments

Comments

@sandersky
Copy link
Contributor

frost-textarea is missing the align property found on frost-text. I think this property should be added in case a consumer of this project wants to support RTL languages/locales.

@notmessenger
Copy link
Contributor

Development notes for when this is implemented:

Per https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element there is no align property supported on textarea elements. There is however a dir that should be used:

Set the element's dir attribute to "ltr" if the user selected a left-to-right writing direction, and "rtl" if the user selected a right-to-left writing direction.

The API that should be exposed on frost-textarea should be the dir attribute and frost-text should be changed as well (though this change should be introduced via a deprecation and continued support of the align property)

@sandersky
Copy link
Contributor Author

I believe align still holds value on the frost-text component as it is used for numeric values (generally numbers are aligned to the right).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants