Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address dependency management issues #227

Closed
39 tasks done
notmessenger opened this issue Nov 27, 2017 · 2 comments · Fixed by #229
Closed
39 tasks done

Address dependency management issues #227

notmessenger opened this issue Nov 27, 2017 · 2 comments · Fixed by #229
Assignees
Labels

Comments

@notmessenger
Copy link
Contributor

notmessenger commented Nov 27, 2017

ciena-frost/ember-frost-popover#61 MUST be resolved before this issue can be addressed. Some of the individual tasks may be able to be worked on before the completion of the dependent issue. If doing so indicate which tasks have been completed by checking them off in the list below, as well as adding a comment to this issue indicating the name of the branch you have pushed to this repo so that work can completed once the dependent task has been addressed.

  • Tasks that have the text "(verified)" after them are ones that have either already been tested or are known to work. This does not mean that you should not still be cautious but you likely don't have to do as much research as you might initially be inclinded to.
  • None of the tasks make a determination of whether a dependency should be a dependency or devDependency UNLESS otherwise stated. Even then it is prudent to confirm this indicator.
  • All dependencies should float to ^ unless the directions in the tasks indicate otherwise.

NPM

  • remove ember-cli-visual-acceptance (verified)
  • determine whether frost-guide-customer-routing is needed
  • remove ember-cli-deploy (verified)
  • remove ember-cli-deploy-frost-pack (verified)
  • determine whether ember-browserify is needed. if so ^1.2.0 is latest
  • npm uninstall ember-frost-test and ember install ember-frost-test (verified)
    • ember-cli-chai will be updated to 0.4.3 so may encounter issues
    • ember-cli-mocha will be updated to 0.14.4 so may encounter issues
    • ember-sinon will be updated to ^0.7.0 so may encounter issues
    • ember-test-utils will be updated to ^7.02 so will encounter issues
  • remove eslint from (verified)
  • remove eslint-config-frost-standard (verified)
  • remove remark-lint (verified)
  • remove sass-lint (verified)
  • pin ember-cli-code-coverage to 0.3.12
  • verify ember-cli-code-coverage is tied into "npm run test" script
  • pin ember-code-snippet to 1.7.0
  • upgrade ember-cli-sass to pinned 7.1.1 (verified)
  • determine whether ember-hook needs to be a dependency
  • downgrade and pin liquid-fire to 0.27.2
  • remove ember-redux
  • remove redux
  • remove redux-thunk
  • remove frost-guide-custom-routing
  • update or install ember-cli-frost-blueprints to ^5.0.0 (or whatever the latest release is) as devDependency
  • check whether these are specifically needed or not and remove if not, otherwise move to dependencies
    • ember-computed-decorators
    • ember-concurrency
    • ember-elsewhere
    • ember-truth-helpers
  • remove ember-prop-types from devDependency and make dependency
  • update ember-prop-types to ^6.0.0 (or whatever the latest release is)
  • update ember-frost-core to ^5.0.0 (or whatever the latest release is)
  • update ember-frost-notifier to latest version
  • update ember-frost-popover to latest version
  • remove useLintTree from ember-cli-mocha configuration in ember-cli-build.js

BOWER

  • move Faker to devDependencies of bower.json
  • move pretender to devDependencies of bower.json
  • remove lodash (verified)
@notmessenger
Copy link
Contributor Author

JIRA: FROST-595

@notmessenger notmessenger changed the title Remove dependency management from blueprint and address other inconsistencies in package.json Address dependency management issues Dec 20, 2017
@notmessenger
Copy link
Contributor Author

ember-frost-popover needs upgraded to ^8.0.0 once released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant