Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PID file path configurable in ksmbd.conf #304

Open
farnoy opened this issue Sep 6, 2023 · 3 comments
Open

Make PID file path configurable in ksmbd.conf #304

farnoy opened this issue Sep 6, 2023 · 3 comments

Comments

@farnoy
Copy link

farnoy commented Sep 6, 2023

Right now, the location of the PID file is hardcoded at compile time and can be changed with --with-rundir. Is there a reason this can't be a runtime choice, same as --config or --users?

SYSCONFDIR is also hardcoded in the same way:

#define PATH_PWDDB SYSCONFDIR "/ksmbd/ksmbdpwd.db"
#define PATH_SMBCONF SYSCONFDIR "/ksmbd/ksmbd.conf"
#define PATH_SMBCONF_FALLBACK SYSCONFDIR "/ksmbd/smb.conf"
#define PATH_SUBAUTH SYSCONFDIR "/ksmbd/ksmbd.subauth"

I understand there was only meant to be one ksmbd running on a system, but with network namespaces, this would be a nice thing to have.

@namjaejeon
Copy link
Member

@atheik Can you answer about this question ?

@atheik
Copy link
Member

atheik commented Sep 9, 2023

@farnoy,

Sure, I don't see why not. It could be both a global parameter and an option, with the latter having precedence. I am not familiar with the network namespaces use case, but I am guessing you would want runtime control of the subauth file as well?

@farnoy
Copy link
Author

farnoy commented Nov 21, 2023

I don't remember what I meant about network namespaces. I'm not interested in that personally. Just wanted to specify the state & configuration files at runtime and not have it hardcoded to the constant value at compile time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants