Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Share with note" on Google Reader doesn't work #38

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

"Share with note" on Google Reader doesn't work #38

GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Go to Google Reader and open the reading list
2. Click on "Share with note" below any reading item

What is the expected output? What do you see instead?
Expect: It should open a floating box on the right top of the page.
Actual: The floating box doesn't show. Console says:
Uncaught TypeError: Cannot set property scrollTop of #<an HTMLBodyElement> 
which has only a getter

Original issue reported on code.google.com by jingz...@google.com on 11 Oct 2010 at 3:12

@GoogleCodeExporter
Copy link
Author

You should also change the setter like this:
document.body.__defineSetter__('scrollTop',
  function(value) {
    window.scrollTo(window.scrollX, value);
  }
);

Original comment by wangxian...@google.com on 11 Oct 2010 at 3:18

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Thanks for the hints! I've fixed it and pushed version 2.0.6.

Original comment by jingz...@google.com on 11 Oct 2010 at 12:18

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant