ingress: rename, group and move consts

This commit renames and moves the Ingress related constants to
the corresponding annotation package.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>

operator/pkg/ingress/annotations/annotations.go

@@ -47,6 +47,11 @@ const (
 	defaultWebsocketEnabled          = 0 // 1 - Enabled, 0 - Disabled
 )
 
+const (
+	LoadbalancerModeDedicated = "dedicated"
+	LoadbalancerModeShared    = "shared"
+)
+
 // GetAnnotationIngressLoadbalancerMode returns the loadbalancer mode for the ingress if possible.
 func GetAnnotationIngressLoadbalancerMode(ingress *networkingv1.Ingress) string {
 	value, _ := annotation.Get(ingress, LBModeAnnotation, LBModeAnnotationAlias)

operator/pkg/ingress/ingress.go

@@ -17,11 +17,7 @@ import (
 
 const (
 	ciliumIngressPrefix    = "cilium-ingress"
-	ciliumIngressLabelKey  = "cilium.io/ingress"
 	ciliumIngressClassName = "cilium"
-
-	dedicatedLoadbalancerMode = "dedicated"
-	sharedLoadbalancerMode    = "shared"
 )
 
 // ingressReconciler reconciles a Ingress object

operator/pkg/ingress/ingress_reconcile.go

@@ -427,11 +427,11 @@ func convertToNetworkV1IngressLoadBalancerIngress(lbIngresses []corev1.LoadBalan
 func (r *ingressReconciler) isEffectiveLoadbalancerModeDedicated(ing *networkingv1.Ingress) bool {
 	value := annotations.GetAnnotationIngressLoadbalancerMode(ing)
 	switch value {
-	case dedicatedLoadbalancerMode:
+	case annotations.LoadbalancerModeDedicated:
 		return true
-	case sharedLoadbalancerMode:
+	case annotations.LoadbalancerModeShared:
 		return false
 	default:
-		return r.defaultLoadbalancerMode == dedicatedLoadbalancerMode
+		return r.defaultLoadbalancerMode == annotations.LoadbalancerModeDedicated
 	}
 }