Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unstripped cilium image binary #10606

Closed
aanm opened this issue Mar 17, 2020 · 2 comments · Fixed by #11689
Closed

Create unstripped cilium image binary #10606

aanm opened this issue Mar 17, 2020 · 2 comments · Fixed by #11689
Assignees
Labels
kind/feature This introduces new functionality.

Comments

@aanm
Copy link
Member

aanm commented Mar 17, 2020

follow up of #10167 (comment)

@aanm aanm added priority/release-blocker kind/feature This introduces new functionality. labels Mar 17, 2020
@tgraf
Copy link
Member

tgraf commented Mar 17, 2020

Moving the discussion from #10167 to this issue

@tgraf we need an unstripped binary in case we want to debug a live cilium process. If that live process is running the stripped binary we should have the unstripped binary also available.

What exact operation is to debug? Are you talking about running a debugger? Are you talking about gops debugging? How commonly do we need this information available right now?

I assume users will typically run the unstripped version and we would require them to run a different image and reproduce? Is a Makefile target to build unstripped images on demand sufficient?

@aanm
Copy link
Member Author

aanm commented Mar 17, 2020

Moving the discussion from #10167 to this issue

@tgraf we need an unstripped binary in case we want to debug a live cilium process. If that live process is running the stripped binary we should have the unstripped binary also available.

What exact operation is to debug? Are you talking about running a debugger? Are you talking about gops debugging? How commonly do we need this information available right now?

My reply was based on the entire discussion of that PR, yes running with delve or gdb.

I assume users will typically run the unstripped version and we would require them to run a different image and reproduce? Is a Makefile target to build unstripped images on demand sufficient?

It's not a matter of how commonly we need it but a matter of when we will need it would be better to have it prepared. My understanding is that users will run the stripped version, not the unstripped version. Having a unstripped binary already build will make sure that:

  1. The stripped version was definitely created from the unstripped version.
  2. The developer helping the user does not need to setup an development environment to build the exact unstripped version of the cilium-agent the user is running. This might include exact golang version for example.
  3. Making the binary available for the user for live debugging would already exist so there is not need for the developer to share binaries build on step 2). The user would simply need to run docker create --name cilium-v1.7.1 docker.io/cilium/cilium-unstripped:v1.7.1 && docker cp cilium-v1.7.1:/usr/bin/cilium-agent ./

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature This introduces new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants