Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade/downgrade test with non-default options #14884

Closed
pchaigno opened this issue Feb 8, 2021 · 5 comments
Closed

Upgrade/downgrade test with non-default options #14884

pchaigno opened this issue Feb 8, 2021 · 5 comments
Assignees
@brb
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. sig/agent Cilium agent related.

Comments

@pchaigno
Copy link
Member

pchaigno commented Feb 8, 2021 •
edited

Apart for a few exceptions, our current upgrade/downgrade test runs with Cilium's default Helm options. We should also run the same test with non-default options (e.g., endpointRoutes.enabled=true, tunnel=disabled, encryption.enabled=true, remoteNodeIdentity=false).

Related: #14883 and #14882.
@pchaigno pchaigno added good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. area/CI-improvement Topic or proposal to improve the Continuous Integration workflow labels Feb 8, 2021
@ti-mo ti-mo linked a pull request Jun 21, 2023 that will close this issue
WIP: ci-e2e: upgrade tests #25790
Closed
@ti-mo
Copy link
Contributor

ti-mo commented Jun 21, 2023

@brb is tackling this in ci-e2e: #25790. Set this issue to close when merged.

@ti-mo ti-mo added area/CI Continuous Integration testing issue or flake sig/agent Cilium agent related. labels Jun 21, 2023
@julianwiedmann
Copy link
Member

@brb wdyt, do we have enough progress in the upgrade workflows to close this issue out? Or are there still tasks remaining that we should list here?

@pchaigno
Copy link
Member Author

pchaigno commented May 7, 2024

I don't think we cover remoteNodeIdentity and that has caused upgrade issues in the past (a long time ago though).

@julianwiedmann
Copy link
Member

I don't think we cover remoteNodeIdentity and that has caused upgrade issues in the past (a long time ago though).

At least for main that's no concern anymore 😁 #31228

@brb
Copy link
Member

brb commented May 9, 2024

Yep, we can close it - ci-e2e-upgrade, ci-ipsec-ugprade, ci-clustermesh do test the upgrade/downgrade with non-defaults.

@brb brb closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brb brb

Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. sig/agent Cilium agent related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: ci-e2e: upgrade tests cilium/cilium
4 participants
@brb @pchaigno @ti-mo @julianwiedmann