Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable per-endpoint routes by default #14955

Open
6 of 12 tasks
pchaigno opened this issue Feb 12, 2021 · 7 comments
Open
6 of 12 tasks

Enable per-endpoint routes by default #14955

pchaigno opened this issue Feb 12, 2021 · 7 comments
Labels
kind/meta Meta-task for co-ordination. pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@pchaigno
Copy link
Member

pchaigno commented Feb 12, 2021

Per-endpoint routes (enable-endpoint-routes) are currently disabled by default. We want to enable them by default for 1.10, mostly as a workaround for #10645. This is a meta issue to track progress on that work item.

@pchaigno pchaigno added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/meta Meta-task for co-ordination. labels Feb 12, 2021
@pchaigno pchaigno added this to Feature candidates in 1.10.0 Feb 12, 2021
@pchaigno pchaigno self-assigned this Feb 12, 2021
@pchaigno pchaigno removed their assignment Jun 11, 2021
@joestringer
Copy link
Member

joestringer commented Jul 2, 2021

Just linking in issue #16717 here, seemed like a case where if we had a mix of endpoints with endpoint-routes enabled + endpoint-routes disabled, it could cause forwarding issues between the endpoints. One longer-term approach to solving that issue is to support endpoints in different modes concurrently. An alternative approach would be to support endpoint routes with all other configurations (per the goal of this issue) and switch to this by default.

@brb brb removed this from Feature candidates (best effort) in 1.10.0 Sep 28, 2021
@brb brb added this to the 1.12 milestone Sep 28, 2021
@brb brb removed this from the 1.12 milestone Jan 21, 2022
@m-yosefpor
Copy link
Contributor

are there any plans to have this in 1.13 milestone?

@pchaigno
Copy link
Member Author

Hi @m-yosefpor 👋 You should already be able to enable endpoint routes in your cluster if you need it. Or is there a reason you need it to be enabled by default?

@m-yosefpor
Copy link
Contributor

Hi @pchaigno . Actually the problem is endpoint routes cannot be enabled together with BPF host routing. Having endpoint routes enabled by default is not our requirement, but one of the items listed here in the check list (#14240) is essential for us.

@pchaigno
Copy link
Member Author

Ok 👍 As far as I know, there are no plans to address #14240 for v1.12 or v1.13. It's something we'd like to address but it's not prioritized right now.

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 9, 2022
@pchaigno pchaigno added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Jul 9, 2022
@gandro
Copy link
Member

gandro commented Oct 26, 2023

Another discrepancy: #28812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta Meta-task for co-ordination. pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

No branches or pull requests

5 participants