Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting started guides in v1.10 CLI-based docs install v1.9 #16512

Closed
pchaigno opened this issue Jun 11, 2021 · 5 comments
Closed

Getting started guides in v1.10 CLI-based docs install v1.9 #16512

pchaigno opened this issue Jun 11, 2021 · 5 comments
Labels
area/cli Impacts the command line interface of any command in the repository. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/bug This is a bug in the Cilium logic. pinned These issues are not marked stale by our issue bot. requires-doc-change Requires updates to the documentation as part of the development effort. sig/agent Cilium agent related.

Comments

@pchaigno
Copy link
Member

The getting started guides for the default (CLI-based) installation in the v1.10 documentation recommend to run:

cilium install

That command will install v1.9.x, not v1.10.

Instead, we should pass a version explicitly:

cilium install --version v1.10.0
@pchaigno pchaigno added kind/bug This is a bug in the Cilium logic. requires-doc-change Requires updates to the documentation as part of the development effort. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. labels Jun 11, 2021
@stale
Copy link

stale bot commented Aug 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 22, 2021
@pchaigno pchaigno added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Aug 23, 2021
@joestringer
Copy link
Member

It should be possible to use parsed-literals to pick up the current version and fix this up.

@ti-mo
Copy link
Contributor

ti-mo commented Jun 21, 2023

Isn't it intended behaviour for cilium install to pick the latest version it knows about? If the user is running a cilium-cli that's too old with a newer version of the docs, it will probably throw an error or result in an unhealthy deployment.

@ti-mo ti-mo added area/cli Impacts the command line interface of any command in the repository. sig/agent Cilium agent related. labels Jun 21, 2023
@pchaigno
Copy link
Member Author

That's the intended default behavior, but if someone is reading the v1.11 installation guide, I think the commands provided should install v1.11, not v1.13.

@aanm
Copy link
Member

aanm commented Feb 29, 2024

Fixed with #26934

@aanm aanm closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/bug This is a bug in the Cilium logic. pinned These issues are not marked stale by our issue bot. requires-doc-change Requires updates to the documentation as part of the development effort. sig/agent Cilium agent related.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joestringer @pchaigno @ti-mo @aanm