Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cilium-operator-resource-quota scopeselector is too broad #20285

Open
stonith opened this issue Jun 22, 2022 · 3 comments
Open

cilium-operator-resource-quota scopeselector is too broad #20285

stonith opened this issue Jun 22, 2022 · 3 comments
Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. pinned These issues are not marked stale by our issue bot. sig/agent Cilium agent related.

Comments

@stonith
Copy link
Contributor

stonith commented Jun 22, 2022

Bug report

General Information

Cilium CLI version: cilium-cli: 0.11.9 compiled with go1.18.3 on darwin/arm64
Orchestration system version in use: Client Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.8-rc.0.32+3772b5d6bf8c21-dirty", GitCommit:"3772b5d6bf8c21c509a8a12432bfc820a1535e63", GitTreeState:"dirty", BuildDate:"2021-12-11T01:29:41Z", GoVersion:"go1.17.3", Compiler:"gc", Platform:"darwin/arm64"} Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.9-gke.2000", GitCommit:"4b8c7c146733b9eca0f0813a2d9b5ff557e9506b", GitTreeState:"clean", BuildDate:"2022-05-20T09:30:59Z", GoVersion:"go1.16.15b7", Compiler:"gc", Platform:"linux/amd64"}
Platform / infrastructure information: GKE

How to reproduce the issue

  1. cilium install in a large cluster
  2. run kubectl get resourcequotas cilium-operator-resource-quota

RESULT:

NAME                             AGE   REQUEST        LIMIT
cilium-operator-resource-quota   1m   pods: 15/15

The scopeselector is too broad, it catches other GKE pods like the konnectivity-agent:

  scopeSelector:
    matchExpressions:
    - operator: In
      scopeName: PriorityClass
      values:
      - system-cluster-critical
@stonith stonith added the kind/bug This is a bug in the Cilium logic. label Jun 22, 2022
@tklauser
Copy link
Member

It looks like the scopeSelector is defined in the helm charts in the cilium/cilium repo: https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/templates/cilium-resource-quota.yaml

I'm thus transferring this issue to that repository.

@tklauser tklauser transferred this issue from cilium/cilium-cli Jun 22, 2022
@tklauser tklauser added area/helm Impacts helm charts and user deployment experience kind/community-report This was reported by a user in the Cilium community, eg via Slack. labels Jun 22, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Mar 11, 2023
@github-actions
Copy link

This issue has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2023
@tklauser tklauser reopened this Mar 26, 2023
@tklauser tklauser added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Mar 26, 2023
@dylandreimerink dylandreimerink added the sig/agent Cilium agent related. label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. pinned These issues are not marked stale by our issue bot. sig/agent Cilium agent related.
Projects
None yet
Development

No branches or pull requests

4 participants