Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init.sh: move tunnel device setup to Go package #20699

Closed
ti-mo opened this issue Jul 28, 2022 · 1 comment · Fixed by #24876
Closed

init.sh: move tunnel device setup to Go package #20699

ti-mo opened this issue Jul 28, 2022 · 1 comment · Fixed by #24876
Assignees
@rgo3
Labels
pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loader Impacts the loading of BPF programs into the kernel.
Milestone
Deprecate init.sh

Comments

@ti-mo
Copy link
Contributor

ti-mo commented Jul 28, 2022

This is a standalone part, so lift it out of init.sh, rewrite in Go and execute it early in agent startup.

Need input from the team at large to know where this code can land. Might need creation of a new package, or could be added to a related, existing one.

This touches netlink, so in-depth test coverage might need to wait until we have some better netns sandboxing infra in place.
@ti-mo ti-mo added sig/loader Impacts the loading of BPF programs into the kernel. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Jul 28, 2022
@ti-mo ti-mo added this to the Deprecate init.sh milestone Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 2, 2022
@ti-mo ti-mo added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Oct 13, 2022
@ti-mo ti-mo mentioned this issue Mar 27, 2023
Closed
@rgo3 rgo3 mentioned this issue Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgo3 rgo3

Labels
pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Milestone
Deprecate init.sh
Development

Successfully merging a pull request may close this issue.

init.sh,loader: load overlay programs in Go rgo3/cilium
2 participants
@ti-mo @rgo3