Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Create control plane tests for IPsec #20707

Closed
brb opened this issue Jul 29, 2022 · 3 comments
Closed

CI: Create control plane tests for IPsec #20707

brb opened this issue Jul 29, 2022 · 3 comments
Assignees
@jschwinger233
Labels
area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ci/hyperjump feature/ipsec Relates to Cilium's IPsec feature sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@brb
Copy link
Member

brb commented Jul 29, 2022

To have a better coverage of the IPSec integration, we could implement privileged control plane tests in a similar manner as we have done for testing the neighbor entries management - https://github.com/cilium/cilium/blob/v1.12.0/pkg/datapath/linux/node_linux_test.go#L1067.

The test would start multiple node manager instances running in different network namespaces which would configure IPSec among the netns. Then, it would do basic connectivity checks.
@brb brb added area/CI Continuous Integration testing issue or flake ci/hyperjump sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. labels Jul 29, 2022
@jschwinger233 jschwinger233 self-assigned this May 31, 2023
@jschwinger233 jschwinger233 mentioned this issue Jun 1, 2023
Merged
@brb brb changed the title CI: Create control plane tests for IPSec CI: Create control plane tests for IPsec Jun 30, 2023
@pchaigno
Copy link
Member

Do we have any examples of past bugs that would have been caught by such tests, but not by BPF unit tests or end-to-end tests?

@jschwinger233
Copy link
Member

Do we have any examples of past bugs that would have been caught by such tests

If I remember correctly, @brb caught a bug by control plane test, but I couldn't find the record.

@julianwiedmann julianwiedmann added the feature/ipsec Relates to Cilium's IPsec feature label Nov 13, 2023
@brb
Copy link
Member Author

brb commented Apr 15, 2024

This was a unit test - #27280. Anyway, considering that I didn't come up with any scenario, we can close this issue.

@brb brb closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jschwinger233 jschwinger233

Labels
area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ci/hyperjump feature/ipsec Relates to Cilium's IPsec feature sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brb @NikAleksandrov @pchaigno @jschwinger233 @julianwiedmann