Concurrency issues around n.localNode

[aanm]

With e52fe1d, the n.localNode variable is not being protected on all places. For example

cilium/pkg/nodediscovery/nodediscovery.go

Line 373 in 88e6835

if err := n.mutateNodeResource(nodeResource); err != nil {

, which is inside UpdateCiliumNodeResource, is being executed from a public function where the n.localNodeLock is being held sometimes but not everytime.

cc @gandro

[gandro]

I think this is a duplicate of #19884?

But the code might have changed since.

[aanm]

Oh, it might be related but it looks like #19884 references different places 🤔