dns: Set --tofqdns-min-ttl to zero by default #21439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
|
This pull request has not seen any activity since it was marked stale. |
christarazi
reviewed
Nov 18, 2022
github-actions
bot
removed
the
stale
michi-covalent
force-pushed
the
pr/michi/fqdn
branch
2 times, most recently
from
3a1b6ef
to
db8afc6
Compare
michi-covalent
force-pushed
the
pr/michi/fqdn
branch
2 times, most recently
from
c5d75db
to
64e0f6d
Compare
michi-covalent
changed the title
michi-covalent
force-pushed
the
pr/michi/fqdn
branch
from
64e0f6d
to
1ba64a1
Compare
|
/test |
michi-covalent
force-pushed
the
pr/michi/fqdn
branch
from
1ba64a1
to
1eb930a
Compare
|
/test |
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
christarazi
added
kind/enhancement
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
|
This pull request has not seen any activity since it was marked stale. |
christarazi
added
the
dont-merge/needs-rebase
|
@michi-covalent We still want this, right? Any reason for why it's blocked? |
michi-covalent
force-pushed
the
pr/michi/fqdn
branch
from
1eb930a
to
b047981
Compare
|
sorry for the delay chris, i just forgot about this. marked ready for review ✅ |
|
/test |
christarazi
removed
the
dont-merge/needs-rebase
christarazi
approved these changes
Mar 8, 2023
qmonnet
requested changes
Mar 8, 2023
This commit changes the default value of --tofqdns-min-ttl from 3600 seconds to zero. This means Cilium honors the TTLs returned from the upstream DNS server by default. Explicitly configure --tofqdns-min-ttl if you need to preserve the previous behavior that lets applications create new connections within the pre-defined --tofqdns-min-ttl time window after the DNS TTL is expired. --tofqdns-min-ttl setting is no longer needed since the poll-based DNS implementation has been replaced by the proxy-based implementation. Having the minimum TTL set to 1 hour by default adds unnecessary CPU / memory overhead, as Cilium ends up keeping track of expired DNS info. This is especially problematic when the upstream DNS server returns responses with short TTLs and many unique IP addresses. Co-authored-by: Joe Stringer <joe@cilium.io> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/fqdn
branch
from
b047981
to
72d95c7
Compare
|
/test |
kaworu
approved these changes
Mar 10, 2023
qmonnet
approved these changes
Mar 10, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default value of --tofqdns-min-ttl from 3600
seconds to zero. This means Cilium honors the TTLs returned from the
upstream DNS server by default. Explicitly configure --tofqdns-min-ttl
if you need to preserve the previous behavior that lets applications
create new connections within the pre-defined --tofqdns-min-ttl time
window after the DNS TTL is expired.
--tofqdns-min-ttl setting is no longer needed since the poll-based DNS
implementation has been replaced by the proxy-based implementation.
Having the minimum TTL set to 1 hour by default adds unnecessary CPU /
memory overhead, as Cilium ends up keeping track of expired DNS info.
This is especially problematic when the upstream DNS server returns
responses with short TTLs and many unique IP addresses.
Co-authored-by: Joe Stringer joe@cilium.io
Signed-off-by: Michi Mutsuzaki michi@isovalent.com