Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFP: Support GRPCRoute in Cilium Gateway API #21928

Closed
8 tasks
sayboras opened this issue Oct 31, 2022 · 3 comments · Fixed by #28654
Closed
8 tasks

CFP: Support GRPCRoute in Cilium Gateway API #21928

sayboras opened this issue Oct 31, 2022 · 3 comments · Fixed by #28654
Assignees
Labels
area/servicemesh GH issues or PRs regarding servicemesh kind/feature This introduces new functionality. pinned These issues are not marked stale by our issue bot. sig/agent Cilium agent related.

Comments

@sayboras
Copy link
Member

sayboras commented Oct 31, 2022

Cilium Feature Proposal

The first cut for Gateway API was done in #21749, however, we have a couple of follow-up tasks to support more features from Gateway API upstream.

This is to track the work to support GRPCRoute.

Goals

Based on the progress and code re-usability introduced in TLSRoutes we should build a similar implementation of GRPCRoute. This route should re-use logic from both TLS and HTTP routes to route gRPC.

To implement it we should re-use the Envoy logic as an GRPCRoute can be attached to a HTTP(S) Gateway, we can therefore re-use that for TLS termination. Preferably it should use gRPC specific routing in Envoy where possible.

Proposed Solution

TBD

Tasks

@sayboras sayboras added kind/feature This introduces new functionality. area/servicemesh GH issues or PRs regarding servicemesh labels Oct 31, 2022
@aanm aanm added the sig/agent Cilium agent related. label Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 8, 2023
@sayboras sayboras added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Jan 8, 2023
@networkop
Copy link
Contributor

networkop commented Jun 15, 2023

Need to test this against our hubble-ui as an additional validation check

@meyskens meyskens assigned sayboras and unassigned meyskens Aug 22, 2023
@sayboras
Copy link
Member Author

sayboras commented Oct 9, 2023

Addressed by #28464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/servicemesh GH issues or PRs regarding servicemesh kind/feature This introduces new functionality. pinned These issues are not marked stale by our issue bot. sig/agent Cilium agent related.
Projects
None yet
4 participants