Extend ipcache key with ClusterID #22200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutaroHayakawa
added
sig/datapath
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-overlapping-podcidr-oss-ipcache
branch
7 times, most recently
from
4302118
to
40dc1f2
Compare
joestringer
added
upgrade-impact
|
@YutaroHayakawa will this impact upcoming 1.14 or later features? If yes we may consider for 1.13, otherwise let's remove the 1.13 release blocker label. |
joestringer
removed
the
release-blocker/1.13
|
Discussed out-of-band with Yutaro, no need for release-blocker label here. |
|
@jrajahalme @NikAleksandrov Hi, I'm glad if I can have some 👀 on this PR 🙏 |
NikAleksandrov
approved these changes
Dec 13, 2022
|
/test |
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-overlapping-podcidr-oss-ipcache
branch
from
40dc1f2
to
a15271b
Compare
|
Rebased on the latest master. |
|
/test |
YutaroHayakawa
added
the
ready-to-merge
|
A review is in, and CI is passing. Let me mark this ready-to-merge. |
ldelossa
approved these changes
Jan 5, 2023
| @@ -218,3 +218,22 @@ func (ac AddrCluster) As20() (ac20 [20]byte) { | |||
| func (ac AddrCluster) AsNetIP() net.IP { | |||
| return ac.addr.AsSlice() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Nit: maybe add some comments about what this structure is representing?
maintainer-s-little-helper
bot
removed
ready-to-merge
Introduce a new type PrefixCluster which holds IP prefix and CluterID. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Consume one padding slot and encode cluster_id into struct ipcache_key. This fields will be used to lookup tunnel endpoint and security identity of the remote cluster with overlapping PodCIDR. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
With Cluster Mesh with overlapping PodCIDR, remote endpoints must be identified using IP + ClusterID. Thus, ipcache lookup must be changed as well. This commit changes function signature and doesn't contain any code to use that. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-overlapping-podcidr-oss-ipcache
branch
from
a15271b
to
0c7514a
Compare
|
Added comments. |
|
/test |
YutaroHayakawa
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the Cluster Mesh with overlapping PodCIDR support. When the remote cluster has an overlapping PodCIDR, we must identify the remote endpoint using IP + ClusterID. This PR makes the required changes for ipcache to realize that. Note that this PR only adds infrastructure, and currently, we don't "use" that. Please review commit by commit.