New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add toEntities/fromEntities CRD description missing options #22279
add toEntities/fromEntities CRD description missing options #22279
Conversation
Many CI tests are still failing, some changes are missing.
@slayer321 Thanks for the pull request! Please have a look at the failing CI checks. Some of them are failing because of missing changes (e.g., files that need to be regenerated). I've switched the PR to draft mode until this is addressed. |
@pchaigno When I'm running this command
This is where my cilium project resides |
@slayer321 Could you ask in Slack? I'm not seeing the issue but others may spot it. |
It should be at |
9b1095c
to
1263445
Compare
Signed-off-by: Sachin Maurya <sachin.maurya7666@gmail.com>
1263445
to
e439c2d
Compare
@chancez I tried running the |
hey @slayer321, the changes in this PR are modifying a auto-generated file. The changes should be done here and then you should run the |
e1051d7
to
0c6ae96
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: --global <sachin.maurya7666@gmail.com>
0c6ae96
to
54bca27
Compare
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Hey @aanm , I made the changes in the file you mentioned and then when I run Below I'm sharing the exit code for the make command
|
@slayer321 Also run |
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Signed-off-by: Sachin Maurya sachin.maurya7666@gmail.com
add all the Entities options from docs
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #22235