Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use &netlink.LinkNotFoundError{} to determine link not found error #22438

Merged
merged 1 commit into from Jan 11, 2023
Merged

Use &netlink.LinkNotFoundError{} to determine link not found error #22438

merged 1 commit into from Jan 11, 2023

Conversation

tanberBro
Copy link
Contributor

Signed-off-by: tanberBro pengfei.song@daocloud.io

This error handling is more elegant. like this

cilium/daemon/cmd/daemon.go

Line 333 in a564d01

if errors.As(err, &netlink.LinkNotFoundError{}) && restoredIP == nil {

@tanberBro tanberBro requested a review from a team as a code owner November 30, 2022 01:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 30, 2022
@maintainer-s-little-helper
Copy link

Commit da5109519c769b451634d3bb3d0258da2a772618 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 30, 2022
@tanberBro tanberBro requested a review from a team as a code owner November 30, 2022 02:26
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 30, 2022
@aanm aanm added the kind/community-contribution This was a contribution made by a community member. label Dec 1, 2022
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Dec 4, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 4, 2023
@ldelossa
Copy link
Contributor

ldelossa commented Jan 6, 2023

@tanberBro sorry for delay, this looks good. can you rebase on latest master?

@aditighag
Copy link
Member

@tanberBro Please rebase the PR to fix the Travis failure.

@aditighag aditighag added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jan 7, 2023
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 7, 2023
netlink.LinkByName: elegant error handling
3127217 
use &netlink.LinkNotFoundError{} handling netlink.LinkByName returned not found error.

Signed-off-by: tanberBro <pengfei.song@daocloud.io>
@tanberBro
Copy link
Contributor Author

@ldelossa @aditighag

@ldelossa
Copy link
Contributor

/test

@tanberBro
Copy link
Contributor Author

@ldelossa

@ldelossa ldelossa added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Jan 11, 2023
@aditighag aditighag merged commit 2b4a7f3 into cilium:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@NikAleksandrov NikAleksandrov Awaiting requested review from NikAleksandrov NikAleksandrov was automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tanberBro @ldelossa @aditighag @joestringer @aanm