Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux node handler: add initial fuzz coverage #22577

Merged
merged 1 commit into from Jan 27, 2023
Merged

Conversation

AdamKorcz
Copy link
Contributor

Signed-off-by: AdamKorcz adam@adalogics.com

Adds a fuzzer that creates a linux node handler, adds a node, refreshes, deletes, and refreshes again.
This fuzzer is meant to add initial fuzz test coverage of the linux node handler.

Add initial fuzz coverage of linux node handler.

@AdamKorcz AdamKorcz requested a review from a team as a code owner December 6, 2022 15:08
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 6, 2022
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 6, 2023
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz
Copy link
Contributor Author

Rebased

@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 12, 2023
@dylandreimerink
Copy link
Member

Hi @AdamKorcz, sorry you have had to wait so long for a reply on this PR, it slipped through the cracks. I stumbled upon this PR just now during some cleanup work.

I am vaguely aware of the fact that there are fuzzers running somewhere, but I believe those pre-date the official go fuzzing framework. How will we utilize these new fuzzing targets and will they get picked up by the existing systems?

Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks sane to me

@dylandreimerink
Copy link
Member

dylandreimerink commented Jan 25, 2023

/test

Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed:

Click to show.

Test Name

K8sDatapathConfig Encapsulation Check connectivity with transparent encryption, VXLAN, and endpoint routes

Failure Output

FAIL: Kubernetes DNS did not become ready in time

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-5.4 so I can create one.

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig Encapsulation Check connectivity with transparent encryption, VXLAN, and endpoint routes

Failure Output

FAIL: Kubernetes DNS did not become ready in time

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@aanm aanm added the release-note/ci This PR makes changes to the CI. label Jan 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2023
@aanm aanm merged commit 11ba1cc into cilium:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants