fuzzing: run latest fuzzers in OSS-Fuzz #22580
Conversation
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
| @@ -1,3 +1,13 @@ | |||
| #/bin/bash -eu | |||
| printf "package policy\nimport _ \"github.com/AdamKorcz/go-118-fuzz-build/testing\"\n" > $SRC/cilium/pkg/policy/registerfuzzdep.go | |||
| go mod tidy && go mod vendor | |||
| mv $SRC/cilium/pkg/policy/l4_filter_test.go $SRC/cilium/pkg/policy/l4_filter_test_fuzz.go | |||
There was a problem hiding this comment.
Can you explain why we need to move these files around and where is this file being run? Can it be run locally by developers?
Maybe we should just move all fuzzing tests from l4_filter_test.go to l4_filter_test_fuzz.go and not bother with moving the files around?
There was a problem hiding this comment.
the oss-fuzz-build.sh is meant to only be run inside the OSS-Fuzz build environment. In that environment, the fuzzers are built with go build which doesn't include _test.go files in its scope and they are therefore renamed. When run locally by developers with go test -fuzz then the renaming is not necessary.
| @@ -1,3 +1,13 @@ | |||
| #/bin/bash -eu | |||
| printf "package policy\nimport _ \"github.com/AdamKorcz/go-118-fuzz-build/testing\"\n" > $SRC/cilium/pkg/policy/registerfuzzdep.go | |||
There was a problem hiding this comment.
I assume that this is done to not import fuzzing libs in policy package for building agent/whatever else might use policy package?
There was a problem hiding this comment.
This is done because OSS-Fuzz rewrites the testing types to ones compatible with libFuzzer which is the fuzzing engine used by OSS-Fuzz.
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Friendly ping 👋 |
This PR adds multiple fuzzers to Ciliums OSS-Fuzz build script. OSS-Fuzz will build the fuzzers and run them continuously. Ciliums OSS-Fuzz integration can be found here: https://github.com/google/oss-fuzz/tree/master/projects/cilium - the build script will invoke Ciliums upstream OSS-Fuzz build script Signed-off-by: AdamKorcz <adam@adalogics.com>
Done! |
Signed-off-by: AdamKorcz adam@adalogics.com
Builds the recently added fuzzers in OSS-Fuzz.