workflow: Reenable L7 tests on EKS + IPsec #22617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
pchaigno
force-pushed
the
pr/pchaigno/reenable-workflow-eks-ipsec-l7
branch
from
1f57e70
to
1065c98
Compare
aanm
added
the
dont-merge/needs-rebase
We've recently reenabled IPsec tests on EKS; it's time to try to reenable the L7 portion of those tests. It seems likely to be working because the connectivity tests now includes new L7 tests that are not disabled here and those are passing. We've also made a fair amount of changes (refactoring and one seemingly unrelated fix) to IPsec recently, so maybe we fixed whatever issue we had there for L7. Signed-off-by: Paul Chaignon <paul@cilium.io>
The few new tests that were added are enough for the EKS workflow to reach its timeout once in a while (2 out of 10 tests). Let's bump it. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/reenable-workflow-eks-ipsec-l7
branch
from
1065c98
to
d4b695c
Compare
christarazi
approved these changes
Dec 9, 2022
pchaigno
removed
the
dont-merge/needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reenables the L7 tests in the IPsec portion of the EKS workflow as they seem to be fixed.
10 runs and discovered that this change may cause the timeout to be reached (2/10). After fixing that, the workflow ran successfully 20 more times. One example of the 5 parallel runs: https://github.com/cilium/cilium/actions/runs/3650907671.
Fixes: #17139.