daemon, ipcache: Plumb root context to IP identity watcher #22626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
area/daemon
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
/test |
christarazi
removed
the
kind/community-contribution
christarazi
force-pushed
the
pr/christarazi/ctx-ipcache-watch
branch
from
520b14c
to
4f93495
Compare
gandro
approved these changes
Dec 13, 2022
In the case that the Agent goes down, it can properly signal to the ipcache package to tear down the IP identity watcher goroutine. This doesn't resolve any bugs that I'm aware of and just found it via code inspection. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/ctx-ipcache-watch
branch
from
4f93495
to
30f39f6
Compare
|
/test |
|
Marking ready to merge because CI has passed for all required jobs and we have approving reviews. |
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the Agent goes down, it can properly signal to the
ipcache package to tear down the IP identity watcher goroutine.
This doesn't resolve any bugs that I'm aware of and just found it via
code inspection.
Signed-off-by: Chris Tarazi chris@isovalent.com