Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: support toggle bootstrap times metric via daemon config #22643

Merged
merged 1 commit into from
Jan 27, 2023
Merged

metrics: support toggle bootstrap times metric via daemon config #22643

merged 1 commit into from
Jan 27, 2023

Conversation

ArthurChiao
Copy link
Contributor

With this patch, we can toggle the cilium_agent_bootstrap_seconds metric with --metrics option. Such as, disable this metric with --metrics="-cilium_agent_bootstrap_seconds", which could save a lot of prometheus storage space for large clusters.

Signed-off-by: ArthurChiao arthurchiao@hotmail.com

@ArthurChiao ArthurChiao requested review from a team as code owners December 9, 2022 09:01
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 9, 2022
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 9, 2022
@ArthurChiao ArthurChiao force-pushed the move_bootstrap_metrics_to_default_list_github branch from 5af425b to 9cc4ba6 Compare December 12, 2022 02:34
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 12, 2023
@ArthurChiao
metrics: support toggle bootstrap times metric via daemon config
ea3cfa8 
With this patch, we can toggle the cilium_agent_bootstrap_seconds metric
with `--metrics` option. Such as, disable this metric with
`--metrics="-cilium_agent_bootstrap_seconds"`, which could save a lot of
prometheus storage space for large clusters.

Signed-off-by: ArthurChiao <ArthurChiao@users.noreply.github.com>
@ArthurChiao ArthurChiao force-pushed the move_bootstrap_metrics_to_default_list_github branch from 9cc4ba6 to ea3cfa8 Compare January 12, 2023 04:26
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jan 13, 2023
@tommyp1ckles
Copy link
Contributor

nice changes, thanks!

@tommyp1ckles
Copy link
Contributor

/test

@aanm aanm added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2023
@aanm aanm merged commit 7ec3ce2 into cilium:master Jan 27, 2023
@ArthurChiao ArthurChiao deleted the move_bootstrap_metrics_to_default_list_github branch January 28, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArthurChiao @tommyp1ckles @aanm