vendor: bump golang-lru to v2 (requires Go >= 1.18 support for generics) #22644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golang-lru package is used in Hubble's L7 parser to maintain a cache of trace ID and timestamp. The new major version of github.com/hashicorp/golang-lru uses Go generics and thus Go >= v1.18 is required (this is already enforced via the go.mod file). Switching to generics means breaking changes in the package's API as, when declaring a new lru.Cache or invoking lru.New, the type of keys and values must be specified. However, this means that we can know trust the types of the key/value pairs we have in the cache and don't need to do any type assertion. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
release-note/misc
|
Travis tests pass and the changes are only covered by Hubble unit tests. Marking as ready to merge. |
rolinh
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golang-lru package is used in Hubble's L7 parser to maintain a cache of trace ID and timestamp.
The new major version of github.com/hashicorp/golang-lru uses Go generics and thus Go >= v1.18 is required (this is already enforced via the go.mod file). Switching to generics means breaking changes in the package's API as, when declaring a new lru.Cache or invoking lru.New, the type of keys and values must be specified. However, this means that we can know trust the types of the key/value pairs we have in the cache and don't need to do any type assertion.