ci: remove test namespace deletion workaround in GKE v1.12 workflow #22655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the workaround for cilium/cilium-cli#255 added in commit b6a5b5b ("conformance-gke-v1.12: Miscellaneous fixes") The cilium-cli issue was fixed in cilium/cilium-cli#1137 and has been in cilium-cli since version v0.12.5. Signed-off-by: Tobias Klauser <tobias@cilium.io>
aanm
approved these changes
Dec 9, 2022
michi-covalent
approved these changes
Dec 9, 2022
nebril
approved these changes
Dec 12, 2022
tklauser
added a commit
that referenced
this pull request
Dec 13, 2022
Signed-off-by: Tobias Klauser <tobias@cilium.io>
|
Test PR #22722 passed on GKE with this change: https://github.com/cilium/cilium/actions/runs/3686621121/jobs/6240741142 All reviews are in, so marking ready to merge. |
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the workaround for
cilium/cilium-cli#255 added in commit b6a5b5b ("conformance-gke-v1.12: Miscellaneous fixes")
The cilium-cli issue was fixed in
cilium/cilium-cli#1137 and has been in cilium-cli since version v0.12.5.